Address platform-specific behavior in TcpStream::shutdown #41499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a few of the other disclaimers of "Platform-specific behavior" I think we have throughout the rest of libstd there's a clause saying "this may change in the future", could that be included as well? Other than that looks good to me. |
carols10cents
added
the
S-waiting-on-author
|
Sounds good to me! @bors: r=alexcrichton rollup |
|
📌 Commit 29e6656 has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 26, 2017
Address platform-specific behavior in TcpStream::shutdown Fixes rust-lang#25164 r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 26, 2017
Address platform-specific behavior in TcpStream::shutdown Fixes rust-lang#25164 r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
bors
added a commit
that referenced
this pull request
Apr 26, 2017
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 26, 2017
Address platform-specific behavior in TcpStream::shutdown Fixes rust-lang#25164 r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 26, 2017
Address platform-specific behavior in TcpStream::shutdown Fixes rust-lang#25164 r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.
bors
added a commit
that referenced
this pull request
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25164
r? @rust-lang/libs from the GitHub thread, it seems like documenting this behavior is okay, but I want to make sure that's what you want.